fix(nuxt): Add import line for disabled autoImport
#13342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
requested review from
a team,
Lms24 and
stephanie-anderson
and removed request for
a team
size-limit report 📦
|
Lms24
approved these changes
Aug 13, 2024
| filename: 'sentry-client-config.mjs', | ||
| getContents: () => | ||
| `import "${buildDirResolver.resolve(`/${clientConfigFile}`)}"\n` + | ||
| 'import { defineNuxtPlugin } from "#imports"\n' + |
There was a problem hiding this comment.
just to check: This does not cause problems if auto import is enabled, right?
There was a problem hiding this comment.
No, this doesn't cause problems. Auto-import just auto-imports if it is not there. If there is an import, it's fine as well. It's always okay to explicitly import. (docs here)
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit imports in case
autoImportis disabled (Nuxt docs here). DisabledautoImportin the E2E test to verify.fixes #13302