fix(astro): Only track access request headers in dynamic page requests #13306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
Lms24
commented
Aug 12, 2024
| 'some-header': 'some-value', | ||
| }), | ||
| }, | ||
| get clientAddress() { |
There was a problem hiding this comment.
This simulates the AstroError that the framework throws if clientAddress is accessed.
mydea
approved these changes
Aug 12, 2024
Lms24
added a commit
that referenced
this pull request
Aug 12, 2024
builds on top of #13306, found while working on #13116 This PR ensures that we correctly extract the request data in our Astro middleware. Previously we didn't convert the `request.headers` object into a `Record<string, string>` but simply passed a `Headers` instance. This caused problems with the `requestDataIntegration` which doesn't handle the instance correctly.
This was referenced Sep 4, 2024
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the Astro SDK which would emerge if users configured their app as SSR output
hybridorserverbut also had static routes.In Astro middleware, we're not allowed to access the
request.headersobject if the incoming request is for a statically generated/prerendered route. Since we accessed these headers previously, users would get a warning as reported multiple times and tracked in #13116fixes #13116
Note: While working on this, I discovered another bug which I'll fix in a follow-up PR. Also, I'll finally add an e2e test app.