chore(lint): Allow ts-ignore in Node integration tests
#13254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/chore-lint-tsignore-node-integ-tests
branch
from
55fcf00 to
0f13518
Compare
Lms24
requested review from
a team,
andreiborza and
mydea
and removed request for
a team
mydea
reviewed
Aug 6, 2024
|
|
||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore | ||
| // @ts-expect-error - response is defined, types just don't reflect it |
There was a problem hiding this comment.
wait but is this not introducing a ts-expect-error?
There was a problem hiding this comment.
lol thx good catch! I guess I changed it back to expect-error to test the rule and the rule was incorrect so it actually still passed 🤦♂️
There was a problem hiding this comment.
Anyway, I adjusted the rule, now it actually throws when you use @ts-expect-error
mydea
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered today that TS 3.8 doesn't understand
// @ts-expect-error. Since we test on Node 22 also with TS 3.8, we shouldn't usets-expect-errorin test files as TS 3.8 would simply ignore the comment and throw a type error.Instead, it's fine to use
@ts-ignorein these test files.