Skip to content

Conversation

@AbhiPrasad
Copy link
Member

As per https://vitest.dev/config/#globals

By default, vitest does not provide global APIs for explicitness

I think we should follow vitest defaults here and explicitly import in the APIs that we need. This refactors our Nestjs SDK tests to do so.

ref #11084

Copy link
Contributor

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@AbhiPrasad AbhiPrasad merged commit 0666eb5 into develop Aug 6, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-vitest-nestjs branch August 6, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants