Skip to content

test(browser): Fix flaky test in test/utils/lazyLoadIntegration.test.ts #13213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

test(browser): Fix flaky test in test/utils/lazyLoadIntegration.test.ts #13213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/browser/test/utils/lazyLoadIntegration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,11 @@ describe('lazyLoadIntegration', () => {
httpClientIntegration: undefined,
};

// We do not await here, as this this does not seem to work with JSDOM :(
// We have browser integration tests to check that this actually works
void lazyLoadIntegration('httpClientIntegration');
try {
await lazyLoadIntegration('httpClientIntegration');
} catch {
// skip
}

expect(global.document.querySelectorAll('script')).toHaveLength(1);
expect(global.document.querySelector('script')?.src).toEqual(
Expand Down