Skip to content

feat(meta-sdks): Remove runtime tags #13105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 31, 2024
Merged

feat(meta-sdks): Remove runtime tags #13105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23059a3
feat(meta-sdks): Remove runtime tags
s1gr1d Jul 30, 2024
e43ec4a
delete runtime tag tests
s1gr1d Jul 30, 2024
5b16de2
delete runtime tag tests 2
s1gr1d Jul 30, 2024
09375a0
Merge branch 'develop' into sig/remove-runtime-tags
s1gr1d Jul 30, 2024
af56abd
delete unused tests
s1gr1d Jul 31, 2024
1431630
Merge branch 'develop' into sig/remove-runtime-tags
s1gr1d Jul 31, 2024
f63a817
trigger CI 1/2
s1gr1d Jul 31, 2024
bf88ba1
trigger CI 2/2
s1gr1d Jul 31, 2024
120cfee
fix remix v1 test
s1gr1d Jul 31, 2024
2a8ef2d
Merge branch 'develop' into sig/remove-runtime-tags
s1gr1d Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dev-packages/e2e-tests/test-applications/create-next-app/tests/client-transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ test('Sends a pageload transaction to Sentry', async ({ page }) => {
expect(transactionEvent).toEqual(
expect.objectContaining({
transaction: '/',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down Expand Up @@ -59,7 +58,6 @@ test('captures a navigation transcation to Sentry', async ({ page }) => {
expect(clientTxnEvent).toEqual(
expect.objectContaining({
transaction: '/user/[id]',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down
4 changes: 0 additions & 4 deletions dev-packages/e2e-tests/test-applications/create-next-app/tests/server-transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ test('Sends server-side transactions to Sentry', async ({ baseURL }) => {
}),
status: 'ok',
},
runtime: {
name: 'node',
version: expect.any(String),
},
}),
spans: [
{
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/nextjs-app-dir/tests/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ test('Sends a pageload transaction', async ({ page }) => {
expect(transactionEvent).toEqual(
expect.objectContaining({
transaction: '/',
tags: { runtime: 'browser' },
transaction_info: { source: 'url' },
type: 'transaction',
contexts: {
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/solidstart/tests/errors.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ test.describe('client-side errors', () => {
},
transaction: '/client-error',
});
expect(error.tags).toMatchObject({ runtime: 'browser' });
expect(error.transaction).toEqual('/client-error');
});
});
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/solidstart/tests/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ test.describe('server-side errors', () => {

const error = await errorEventPromise;

expect(error.tags).toMatchObject({ runtime: 'node' });
expect(error).toMatchObject({
exception: {
values: [
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/errors.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ test.describe('client-side errors', () => {
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });

expect(errorEvent.transaction).toEqual('/client-error');
});

Expand All @@ -53,7 +51,6 @@ test.describe('client-side errors', () => {
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });
expect(errorEvent.transaction).toEqual('/universal-load-error');
});
});
4 changes: 0 additions & 4 deletions dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ test.describe('server-side errors', () => {
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'node' });

expect(errorEvent.request).toEqual({
cookies: {},
headers: expect.objectContaining({
Expand Down Expand Up @@ -49,8 +47,6 @@ test.describe('server-side errors', () => {
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'node' });

expect(errorEvent.request).toEqual({
cookies: {},
headers: expect.objectContaining({
Expand Down
1 change: 0 additions & 1 deletion ...ackages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ test('server pageload request span has nested request span for sub request', asy

expect(serverTxnEvent).toMatchObject({
transaction: 'GET /server-load-fetch',
tags: { runtime: 'node' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down
33 changes: 5 additions & 28 deletions dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ test.describe('performance events', () => {

expect(clientTxnEvent).toMatchObject({
transaction: '/users/[id]',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand All @@ -34,7 +33,6 @@ test.describe('performance events', () => {

expect(serverTxnEvent).toMatchObject({
transaction: 'GET /users/[id]',
tags: { runtime: 'node' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down Expand Up @@ -77,7 +75,6 @@ test.describe('performance events', () => {

expect(clientTxnEvent).toMatchObject({
transaction: '/users',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand All @@ -90,7 +87,6 @@ test.describe('performance events', () => {

expect(serverTxnEvent).toMatchObject({
transaction: 'GET /users',
tags: { runtime: 'node' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down Expand Up @@ -130,7 +126,6 @@ test.describe('performance events', () => {

expect(clientTxnEvent).toMatchObject({
transaction: '/universal-load-fetch',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand All @@ -143,7 +138,6 @@ test.describe('performance events', () => {

expect(serverTxnEvent).toMatchObject({
transaction: 'GET /api/users',
tags: { runtime: 'node' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down Expand Up @@ -186,11 +180,11 @@ test.describe('performance events', () => {

test('captures a navigation transaction directly after pageload', async ({ page }) => {
const clientPageloadTxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
return txnEvent?.contexts?.trace?.op === 'pageload' && txnEvent?.tags?.runtime === 'browser';
return txnEvent?.contexts?.trace?.op === 'pageload';
});

const clientNavigationTxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.tags?.runtime === 'browser';
return txnEvent?.contexts?.trace?.op === 'navigation';
});

await waitForInitialPageload(page, { route: '/' });
Expand All @@ -205,7 +199,6 @@ test.describe('performance events', () => {

expect(pageloadTxnEvent).toMatchObject({
transaction: '/',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand All @@ -218,7 +211,6 @@ test.describe('performance events', () => {

expect(navigationTxnEvent).toMatchObject({
transaction: '/users/[id]',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down Expand Up @@ -253,27 +245,15 @@ test.describe('performance events', () => {

test('captures one navigation transaction per redirect', async ({ page }) => {
const clientNavigationRedirect1TxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
return (
txnEvent?.contexts?.trace?.op === 'navigation' &&
txnEvent?.tags?.runtime === 'browser' &&
txnEvent?.transaction === '/redirect1'
);
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.transaction === '/redirect1';
});

const clientNavigationRedirect2TxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
return (
txnEvent?.contexts?.trace?.op === 'navigation' &&
txnEvent?.tags?.runtime === 'browser' &&
txnEvent?.transaction === '/redirect2'
);
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.transaction === '/redirect2';
});

const clientNavigationRedirect3TxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
return (
txnEvent?.contexts?.trace?.op === 'navigation' &&
txnEvent?.tags?.runtime === 'browser' &&
txnEvent?.transaction === '/users/[id]'
);
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.transaction === '/users/[id]';
});

await waitForInitialPageload(page, { route: '/' });
Expand All @@ -289,7 +269,6 @@ test.describe('performance events', () => {

expect(redirect1TxnEvent).toMatchObject({
transaction: '/redirect1',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down Expand Up @@ -327,7 +306,6 @@ test.describe('performance events', () => {

expect(redirect2TxnEvent).toMatchObject({
transaction: '/redirect2',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down Expand Up @@ -365,7 +343,6 @@ test.describe('performance events', () => {

expect(redirect3TxnEvent).toMatchObject({
transaction: '/users/[id]',
tags: { runtime: 'browser' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down
3 changes: 0 additions & 3 deletions dev-packages/e2e-tests/test-applications/sveltekit-2/tests/errors.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ test.describe('client-side errors', () => {
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });

expect(errorEvent.transaction).toEqual('/client-error');
});

Expand All @@ -53,7 +51,6 @@ test.describe('client-side errors', () => {
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'browser' });
expect(errorEvent.transaction).toEqual('/universal-load-error');
});
});
4 changes: 0 additions & 4 deletions dev-packages/e2e-tests/test-applications/sveltekit-2/tests/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ test.describe('server-side errors', () => {
in_app: true,
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'node' });
});

test('captures server load error', async ({ page }) => {
Expand All @@ -38,8 +36,6 @@ test.describe('server-side errors', () => {
in_app: true,
}),
);

expect(errorEvent.tags).toMatchObject({ runtime: 'node' });
});

test('captures server route (GET) error', async ({ page }) => {
Expand Down
1 change: 0 additions & 1 deletion dev-packages/e2e-tests/test-applications/sveltekit-2/tests/performance.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ test('server pageload request span has nested request span for sub request', asy

expect(serverTxnEvent).toMatchObject({
transaction: 'GET /server-load-fetch',
tags: { runtime: 'node' },
transaction_info: { source: 'route' },
type: 'transaction',
contexts: {
Expand Down
Loading
Loading