feat(vercel-edge): Add dedupe as default integration #12957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Jul 18, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Just out of personal curiosity: Dedupe is only enabled by default in browser and deno, not in node. Should we change this?
Lms24
approved these changes
Jul 18, 2024
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Don't want to block this in the meantime. Sounds like a good idea to add it to vercel-edge from my PoV
Member
Author
I didn't realize it was not enabled in Node. Let me write up a GH issue to discuss this with the wider group. I think it's fine to release this for now because constraining volume of events sent from serverless env is very valuable. |
This was referenced Aug 9, 2024
This was referenced Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the dedupe integration as a default integration to
vercel-edge.Saw this discrepancy while working on the cloudflare sdk.