test(e2e): Do not require DSN to run E2E tests #12743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Jul 3, 2024
mydea
added a commit
that referenced
this pull request
Jul 4, 2024
mydea
force-pushed
the
fn/optional-e2e-env
branch
from
860fad7 to
112d9bd
Compare
size-limit report 📦
|
First, this means it is easier to run this locally. Secondly, we do not even need to send data to Sentry anymore, so we can adjust the proxy server to stop doing this. Lastly, this means that we can also safely run E2E tests for external contributors.
mydea
force-pushed
the
fn/optional-e2e-env
branch
from
c2fb990 to
9e78dee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this means it is easier to run this locally.
Secondly, we do not even need to send data to Sentry anymore, so we can adjust the proxy server to stop doing this.
Lastly, this means that we can also safely run E2E tests for external contributors.
Closes #11910