feat(profiling) add global profile context while profiler is running #12394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Jun 7, 2024
AbhiPrasad
approved these changes
Jun 10, 2024
Member
AbhiPrasad
left a comment
AbhiPrasad
left a comment
There was a problem hiding this comment.
My comments don't block here, let's go with this
| trace: { | ||
| data: expect.objectContaining({ | ||
| ['thread.id']: expect.any(String), | ||
| ['thread.name']: expect.any(String), |
Member
There was a problem hiding this comment.
we should add a test to validate the isMainThread behaviour
Member
|
@JonasBa could you also add a PR description? |
Member
Author
Yup, will clean it up. Sorry about that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attach profile context to events while a profiler is active and assign thread id and name to the trace context.
This will be required by the profiling API so that we can figure out the links between spans and profiles. In the future (span streaming), tid and thread name will be assigned to each span