Skip to content

ci: Fix sveltekit flakes #12327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024
Merged

ci: Fix sveltekit flakes #12327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/sveltekit-2-svelte-5/tests/performance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ test.describe('performance events', () => {
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.tags?.runtime === 'browser';
});

await page.goto('/');
await waitForInitialPageload(page, { route: '/' });

const navigationClickPromise = page.locator('#routeWithParamsLink').click();

Expand Down Expand Up @@ -252,8 +252,6 @@ test.describe('performance events', () => {
});

test('captures one navigation transaction per redirect', async ({ page }) => {
await page.goto('/');

const clientNavigationRedirect1TxnPromise = waitForTransaction('sveltekit-2-svelte-5', txnEvent => {
return (
txnEvent?.contexts?.trace?.op === 'navigation' &&
Expand All @@ -278,6 +276,8 @@ test.describe('performance events', () => {
);
});

await waitForInitialPageload(page, { route: '/' });

const navigationClickPromise = page.locator('#redirectLink').click();

const [redirect1TxnEvent, redirect2TxnEvent, redirect3TxnEvent, _] = await Promise.all([
Expand Down
6 changes: 3 additions & 3 deletions dev-packages/e2e-tests/test-applications/sveltekit-2/tests/performance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ test.describe('performance events', () => {
return txnEvent?.contexts?.trace?.op === 'navigation' && txnEvent?.tags?.runtime === 'browser';
});

await page.goto('/');
await waitForInitialPageload(page, { route: '/' });

const navigationClickPromise = page.locator('#routeWithParamsLink').click();

Expand Down Expand Up @@ -252,8 +252,6 @@ test.describe('performance events', () => {
});

test('captures one navigation transaction per redirect', async ({ page }) => {
await page.goto('/');

const clientNavigationRedirect1TxnPromise = waitForTransaction('sveltekit-2', txnEvent => {
return (
txnEvent?.contexts?.trace?.op === 'navigation' &&
Expand All @@ -278,6 +276,8 @@ test.describe('performance events', () => {
);
});

await waitForInitialPageload(page, { route: '/' });

const navigationClickPromise = page.locator('#redirectLink').click();

const [redirect1TxnEvent, redirect2TxnEvent, redirect3TxnEvent, _] = await Promise.all([
Expand Down