fix(node): Do not manually finish / update root Hapi spans. #12287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/hapi-error-plugin-patch
branch
from
b348a62 to
00dea2a
Compare
AbhiPrasad
changed the title
AbhiPrasad
approved these changes
May 29, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #12260
We're currently attempting to manually update the Hapi route transaction status, followed by
.end()call.Looking at
@opentelemetry/instrumentation-hapis code, it looks like that is already covered by the underlying instrumentation.This PR removes that, also extends tests to make sure the error events and the transactions are linked properly.