fix(core): Pass in cron monitor config correctly #12248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
andreiborza and
mydea
and removed request for
a team
This was referenced May 27, 2024
size-limit report 📦
|
AbhiPrasad
commented
May 27, 2024
Comment on lines
-87
to
-89
| failure_issue_threshold?: number; | ||
| failureIssueThreshold?: SerializedMonitorConfig['failure_issue_threshold']; | ||
| // How many consecutive OK check-ins it takes to resolve an issue. | ||
| recovery_threshold?: number; |
There was a problem hiding this comment.
Although this is technically a breaking change, these values were not used for anything, and are incorrect format, so I'm fine with removing them (they were also not documented anywhere - I opened getsentry/sentry-docs#10168 to document this PR).
mydea
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12217
Make sure
failure_issue_thresholdandrecovery_thresholdget passed in correctly.