Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented May 22, 2024

I noticed we were getting some build warnings for circular dependency issues, which indicated that madge was not correctly capturing all issues. So I went ahead and updated madge to latest, and aligned the setup, which actually surfaced problems again more correctly.

I also fixed all the circular dep issues that were raised there. We still have a bunch of types-related circular deps but these are hard to solve, so let's ignore this for now.

@mydea mydea self-assigned this May 22, 2024
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.72 KB (0%)
@sentry/browser (incl. Tracing) 32.88 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.23 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.61 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.27 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.3 KB (0%)
@sentry/browser (incl. Feedback) 37.71 KB (0%)
@sentry/browser (incl. sendFeedback) 26.29 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.69 KB (0%)
@sentry/react 24.41 KB (+0.01% 🔺)
@sentry/react (incl. Tracing) 35.87 KB (0%)
@sentry/vue 25.66 KB (0%)
@sentry/vue (incl. Tracing) 34.69 KB (0%)
@sentry/svelte 21.86 KB (0%)
CDN Bundle 24.25 KB (-0.06% 🔽)
CDN Bundle (incl. Tracing) 34.32 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing, Replay) 68 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.99 KB (-0.02% 🔽)
CDN Bundle - uncompressed 71.33 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.74 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 211.36 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.72 KB (0%)
@sentry/nextjs (client) 35.09 KB (0%)
@sentry/sveltekit (client) 33.46 KB (0%)
@sentry/node 128.42 KB (+0.01% 🔺)
@sentry/aws-serverless 114.41 KB (-0.01% 🔽)

@mydea mydea merged commit 53d814b into develop May 22, 2024
@mydea mydea deleted the fn/fix-circular-deps branch May 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants