- 
          
 - 
                Notifications
    
You must be signed in to change notification settings  - Fork 1.7k
 
feat(nextjs): Trace pageloads in App Router #12157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
          size-limit report 📦
  | 
    
df92ff1    to
    be78108      
    Compare
  
    be78108    to
    1af861f      
    Compare
  
    
              
                    AbhiPrasad
  
              
              approved these changes
              
                  
                    May 23, 2024 
                  
              
              
            
            
  This was referenced May 27, 2024 
      
| 
           Thanks so much for this, this is awesome! 🚀  | 
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR adds a very basic form of App Router pageload tracing to the Next.js SDK. This will allow us to see server component spans inside the trace, alongside the pageload span.
This works by using the new
experimental.clientTraceMetadataoption added in Next.js 15 (14.3.0-canary.64) which will inject meta tags, containing OTEL trace propagation data. The SDK automatically sets this option when a supporting version is detected.As a side-effect, this allows the SDK to associate errors thrown in server components (server side) with errors captured in error boundaries in the browser.
Example trace:

What doesn't work yet
This PR does not yet include the functionality to attach serverside spans to the request span of the pageload span. This requires some hack that we can explore in a follow-up PR: #12182