Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented May 16, 2024

Our nest e2e test was not fully correct, and did not test the creation of actual nest.js core spans (only http & express spans).

This updates the test setup & check to account for this.

@mydea mydea requested a review from s1gr1d May 16, 2024 14:38
@mydea mydea self-assigned this May 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2024

size-limit report 📦

Path Size
@sentry/browser 21.72 KB (0%)
@sentry/browser (incl. Tracing) 32.86 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.21 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.6 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.25 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.25 KB (0%)
@sentry/browser (incl. Feedback) 37.68 KB (0%)
@sentry/browser (incl. sendFeedback) 26.29 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.66 KB (0%)
@sentry/react 24.41 KB (0%)
@sentry/react (incl. Tracing) 35.85 KB (0%)
@sentry/vue 25.65 KB (0%)
@sentry/vue (incl. Tracing) 34.68 KB (0%)
@sentry/svelte 21.86 KB (0%)
CDN Bundle 24.26 KB (0%)
CDN Bundle (incl. Tracing) 34.29 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.99 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.95 KB (0%)
CDN Bundle - uncompressed 71.33 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.68 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 211.3 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.6 KB (0%)
@sentry/nextjs (client) 35.07 KB (0%)
@sentry/sveltekit (client) 33.44 KB (0%)
@sentry/node 141.32 KB (+0.19% 🔺)
@sentry/aws-serverless 128.08 KB (0%)

@mydea mydea force-pushed the fn/nest-e2e-test branch from 18bda66 to 1c4668e Compare May 16, 2024 14:43
@mydea mydea requested review from Lms24 and andreiborza May 17, 2024 08:47
@mydea mydea merged commit dc9ed37 into develop May 17, 2024
@mydea mydea deleted the fn/nest-e2e-test branch May 17, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants