Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented May 15, 2024

This reverts commit c2ae9bd (PR #12023).

The reason is that we're concerned about 1. the usefulness and 2. the name of this option and would like to revisit this without blocking the 8.1.0 release. This is not semver-breaking because in 8.0.0, this API did not exist.

We still realized that the back and forth here, including us missing this in the migration guide is not optional. Apologies for anyone who's relying on this option at the moment.

@Lms24 Lms24 changed the title Revert "feat(browser): Add interactionsSampleRate to browserTracingIntegration options (#12023)" revert: "feat(browser): Add interactionsSampleRate to browserTracingIntegration options (#12023)" May 15, 2024
@Lms24 Lms24 requested review from a team, andreiborza and s1gr1d and removed request for a team May 15, 2024 13:42
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (added)
@sentry/browser (incl. Tracing) 32.72 KB (added)
@sentry/browser (incl. Tracing, Replay) 68.06 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.46 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.1 KB (added)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.11 KB (added)
@sentry/browser (incl. Feedback) 37.6 KB (added)
@sentry/browser (incl. sendFeedback) 26.23 KB (added)
@sentry/browser (incl. FeedbackAsync) 30.6 KB (added)
@sentry/react 24.36 KB (added)
@sentry/react (incl. Tracing) 35.68 KB (added)
@sentry/vue 25.5 KB (added)
@sentry/vue (incl. Tracing) 34.51 KB (added)
@sentry/svelte 21.8 KB (added)
CDN Bundle 24.21 KB (added)
CDN Bundle (incl. Tracing) 34.13 KB (added)
CDN Bundle (incl. Tracing, Replay) 67.81 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.78 KB (added)
CDN Bundle - uncompressed 71.21 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 101.24 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.86 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.16 KB (added)
@sentry/nextjs (client) 34.92 KB (added)
@sentry/sveltekit (client) 33.28 KB (added)
@sentry/node 140.99 KB (added)
@sentry/aws-serverless 128.03 KB (added)

@Lms24 Lms24 merged commit ef26423 into develop May 16, 2024
@Lms24 Lms24 deleted the lms/revert-12023 branch May 16, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants