Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented May 13, 2024

Let's 🚢 this!

ryan953 and others added 8 commits May 10, 2024 14:49
…n 7.x to 8.0.0 (#11731)

As the User Feedback feature moves from alpha/beta to GA some changes to
the public API have been made, and version requirements for the server
(for on-prem users) are being solidified.

Related to getsentry/develop#1206

---------

Co-authored-by: Catherine Lee <[email protected]>
Co-authored-by: Billy Vong <[email protected]>
[Gitflow] Merge master into develop
When getting the user from the scope, the user can also be an empty
object, which doesn't work with null coalescing. This checks to see if
the user exists and that it's not empty in all scopes

Fixes getsentry/sentry#70347
I dropped the ball on this a bit to deprecate but removing it now should
still be fine.
…11998)

In order to keep bundle size compact, performance integrations (except
for http & fetch) have to be manually added for serverless packages.

This means that users will have to do e.g. this if they want to have
mysql instrumented:

```js
import * as Sentry from '@sentry/aws-serverless';

Sentry.init({
  integrations: [Sentry.mysqlIntegration()]
});
```

Closes #11991

---------

Co-authored-by: Lukas Stracke <[email protected]>
`snapshot` is a public API.

I think the other methods we do not need to expose (?).

With this, usage will be:

```ts
const canvas = getClient()?.getIntegrationByName<ReturnType<typeof replayCanvasIntegration>>('ReplayCanvas');
await canvas.snapshot();
```

Closes #11971
@Lms24
Copy link
Member Author

Lms24 commented May 13, 2024

(supersedes #11948 b/c of branch name)

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets-do-this

@Lms24 Lms24 changed the base branch from develop to master May 13, 2024 14:26
@Lms24 Lms24 requested review from a team as code owners May 13, 2024 14:26
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Replays will fail to start recording when using `start()` specifically
when manually recording and after the user has been idle for a long
period of time. We need to reset the user activity state when we call
`start()`, otherwise the session will be [incorrectly] considered to be
idle and unable to send any replay events.

Closes #11983
@Lms24 Lms24 changed the base branch from master to develop May 13, 2024 14:28
add section for integrations API

cleanup

Apply suggestions from code review

Co-authored-by: Francesco Novy <[email protected]>

rework sdk init section

update changelog
@Lms24 Lms24 force-pushed the prepare-release/8.0.0 branch from 1d96065 to 2e08b05 Compare May 13, 2024 14:30
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎉

@Lms24 Lms24 changed the base branch from develop to master May 13, 2024 14:38
@Lms24 Lms24 merged commit 19648c5 into master May 13, 2024
@Lms24 Lms24 deleted the prepare-release/8.0.0 branch May 13, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants