Skip to content

Conversation

@basarat
Copy link

@basarat basarat commented May 2, 2024

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, good catch!

@mydea
Copy link
Member

mydea commented Jul 2, 2024

This was fixed in the meanwhile via #12598, thank you for the contribution! ❤️

@mydea mydea closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants