feat(react): type error as unknown in ErrorBoundary #11819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
lforst and
stephanie-anderson
and removed request for
a team
mydea
approved these changes
Apr 29, 2024
1 task
jossi87
added a commit
to jossi87/climbing-web
that referenced
this pull request
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11728
As reporting in the above issue, it is not typesafe to type the error thrown by react components as
Error, it can actually be any JS object/primitive that was thrown. This means we have to type everything asunknown.This change only will happen for
8.xbecause it's a breaking change.Related:
unknownDefinitelyTyped/DefinitelyTyped#69434