feat: core/browser additions #1175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamilogorek
suggested changes
Dec 19, 2017
packages/core/__tests__/client.ts
Outdated
| const spy2 = jest.spyOn(sentry.getAdapter(), 'install'); | ||
| await sentry.install(); | ||
| await sentry.install(); | ||
| expect(spy1).toHaveBeenCalledTimes(2); |
Contributor
There was a problem hiding this comment.
This assertion looks redundant, because you trigger those calls yourself 2 lines above
| const spy = jest.spyOn(sentry, 'setRelease'); | ||
| const spy2 = jest.spyOn(sentry.getAdapter(), 'setRelease'); | ||
| await sentry.setRelease('#oops'); | ||
| expect(spy).toBeCalled(); |
|
|
||
| public setUserContext(user?: IUser) { | ||
| public getContext() { | ||
| // TODO: check for cyclic objects |
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Thanks for the review, so about this function. I wasn't able to import the existing implementation and I want to have a fancy typescript and also thinking about if it would be possible to prevent circular refs upon setting it instead of reading.
kamilogorek
approved these changes
Dec 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.