feat(core): Add trace envelope header to span envelope
#11699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/feat-browser-standalone-segment-spans
Lms24
force-pushed
the
lms/feat-browser-standalone-segment-spans
branch
from
1e622f2 to
4c454d4
Compare
Lms24
force-pushed
the
lms/feat-core-span-envelope-trace-header
branch
from
c2537f1 to
558bdd8
Compare
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-browser-standalone-segment-spans
branch
from
4c454d4 to
84d49ca
Compare
Lms24
force-pushed
the
lms/feat-core-span-envelope-trace-header
branch
from
558bdd8 to
238c267
Compare
Lms24
force-pushed
the
lms/feat-browser-standalone-segment-spans
branch
from
84d49ca to
8b3627a
Compare
Lms24
force-pushed
the
lms/feat-core-span-envelope-trace-header
branch
from
238c267 to
3420308
Compare
Lms24
force-pushed
the
lms/feat-core-span-envelope-trace-header
branch
from
3420308 to
082d3b0
Compare
Lms24
commented
Apr 25, 2024
| sample_rate: '1', | ||
| sampled: 'true', | ||
| trace_id: traceId, | ||
| transaction: 'outer', |
There was a problem hiding this comment.
So just to point this out: In a hyptothetical scenario, where a standalone span is created during an active transaction, it's DSC/trace header will be inherited from the active span tree's DSC. I think this is okay for now at least, since it guarantees DS and trace stability as long as one trace is active. Also this scenario is not going to happen in the SDK for how we plan on using standalone for http.client and INP spans.
There was a problem hiding this comment.
makes sense still for it to be this way! 👍
| sample_rate: '1', | ||
| sampled: 'true', | ||
| trace_id: spanJson.trace_id, | ||
| transaction: 'standalone_span', |
There was a problem hiding this comment.
Also worth pointing out: In case of no previously active parent span, like in this test, the standalone span is treated like a transaction DSC/trace header -wise
Lms24
requested review from
a team,
mydea,
s1gr1d and
stephanie-anderson
and removed request for
a team and
stephanie-anderson
|
will rebase this again when #11696 is merged. This should also fix the failing e2e test |
Base automatically changed from
lms/feat-browser-standalone-segment-spans
to
develop
April 25, 2024 14:44
Lms24
force-pushed
the
lms/feat-core-span-envelope-trace-header
branch
from
47a67db to
5095e82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on #11696
This PR adds a
traceenvelope header to our standalone span envelope creation function.ref #11562