Skip to content

fix(node): Ensure DSC on envelope header uses root span #11683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix(node): Ensure DSC on envelope header uses root span #11683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...kages/node-integration-tests/suites/tracing/envelope-header/error-active-span/scenario.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,7 @@ Sentry.init({
});

Sentry.startSpan({ name: 'test span' }, () => {
Sentry.captureException(new Error('foo'));
Sentry.startSpan({ name: 'test inner span' }, () => {
Sentry.captureException(new Error('foo'));
});
});
5 changes: 3 additions & 2 deletions packages/opentelemetry/src/setupEventContextTrace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,13 @@ export function setupEventContextTrace(client: Client): void {
...event.contexts,
};

const rootSpan = getRootSpan(span);

event.sdkProcessingMetadata = {
dynamicSamplingContext: getDynamicSamplingContextFromSpan(span),
dynamicSamplingContext: getDynamicSamplingContextFromSpan(rootSpan),
...event.sdkProcessingMetadata,
};

const rootSpan = getRootSpan(span);
const transactionName = spanHasName(rootSpan) ? rootSpan.name : undefined;
if (transactionName && !event.transaction) {
event.transaction = transactionName;
Expand Down