Skip to content

Conversation

@c298lee
Copy link
Contributor

@c298lee c298lee commented Apr 16, 2024

The timeout id wasn't getting reset to null after submission which was causing additional clicks on the feedback button to pop up the success message instead. Now, a click on the success message brings back the feedback button, which brings up the dialog when clicked.

Fixes #418

@c298lee c298lee requested a review from a team April 16, 2024 00:10
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.16 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) 31.74 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) 67.05 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.47 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.88 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.79 KB (+0.01% 🔺)
@sentry/browser (incl. Feedback) 35.72 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback, Feedback Modal) 35.72 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.75 KB (+0.02% 🔺)
@sentry/browser (incl. sendFeedback) 26.95 KB (-0.01% 🔽)
@sentry/react 24.84 KB (-0.01% 🔽)
@sentry/react (incl. Tracing) 34.64 KB (-0.01% 🔽)
@sentry/vue 25.72 KB (-0.01% 🔽)
@sentry/vue (incl. Tracing) 33.45 KB (-0.01% 🔽)
@sentry/svelte 22.28 KB (-0.02% 🔽)
CDN Bundle 24.47 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing) 32.97 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay) 66.59 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.81 KB (+0.01% 🔺)
CDN Bundle - uncompressed 72.9 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 98.89 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 208.55 KB (-0.01% 🔽)
@sentry/nextjs (client) 34.01 KB (-0.01% 🔽)
@sentry/sveltekit (client) 32.25 KB (-0.01% 🔽)
@sentry/node 120.17 KB (-0.01% 🔽)

@c298lee c298lee merged commit 38758b9 into develop Apr 16, 2024
@c298lee c298lee deleted the cl/feedback-timeout branch April 16, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants