test(browser-integration-tests): Test that errors during pageload/navigation have correct trace id #11610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…igation have correct trace id
Lms24
requested review from
a team,
AbhiPrasad and
lforst
and removed request for
a team
lforst
approved these changes
Apr 15, 2024
dev-packages/browser-integration-tests/suites/tracing/trace-lifetime/pageload/test.ts
Outdated
Show resolved
Hide resolved
…fetime/pageload/test.ts Co-authored-by: Luca Forstner <[email protected]>
Lms24
deleted the
lms/test-browser-error-during-pageload-navigation-correct-trace
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two tests to ensure errors thrown during pageload or navigations have the correct traceId.
(Admittedly, this scenario is pretty obvious and we probably test this in some capacity already but it makes a lot of sense to cover this behaviour in this test suite, too).
ref #11599