Skip to content

feat(opentelemetry): Remove otel.attributes in context #11604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

feat(opentelemetry): Remove otel.attributes in context #11604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions packages/node/test/integration/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,6 @@ describe('Integration | Transactions', () => {
]);

expect(transaction.contexts?.otel).toEqual({
attributes: {
'test.outer': 'test value',
'sentry.op': 'test op',
'sentry.origin': 'auto.test',
'sentry.source': 'task',
},
resource: {
'service.name': 'node',
'service.namespace': 'sentry',
Expand Down Expand Up @@ -245,14 +239,6 @@ describe('Integration | Transactions', () => {
{ message: 'test breadcrumb 3', timestamp: 123456 },
],
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'test.outer': 'test value',
'sentry.op': 'test op',
'sentry.origin': 'auto.test',
'sentry.source': 'task',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down Expand Up @@ -294,12 +280,6 @@ describe('Integration | Transactions', () => {
{ message: 'test breadcrumb 3b', timestamp: 123456 },
],
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'test.outer': 'test value b',
'sentry.op': 'test op b',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down Expand Up @@ -408,11 +388,6 @@ describe('Integration | Transactions', () => {
{ message: 'test breadcrumb 3', timestamp: 123456 },
],
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'test.outer': 'test value',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down Expand Up @@ -449,11 +424,6 @@ describe('Integration | Transactions', () => {
{ message: 'test breadcrumb 3b', timestamp: 123456 },
],
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'test.outer': 'test value b',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down Expand Up @@ -527,13 +497,6 @@ describe('Integration | Transactions', () => {
expect(beforeSendTransaction).toHaveBeenLastCalledWith(
expect.objectContaining({
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'sentry.op': 'test op',
'sentry.origin': 'auto.test',
'sentry.source': 'task',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down
2 changes: 0 additions & 2 deletions packages/opentelemetry/src/spanExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,6 @@ function createTransactionForOtelSpan(span: ReadableSpan): TransactionEvent {
contexts: {
trace: traceContext,
otel: {
// TODO: remove the attributes here?
attributes: removeSentryAttributes(span.attributes),
resource: span.resource.attributes,
},
},
Expand Down
27 changes: 0 additions & 27 deletions packages/opentelemetry/test/integration/transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,6 @@ describe('Integration | Transactions', () => {
]);

expect(transaction.contexts?.otel).toEqual({
attributes: {
'test.outer': 'test value',
'sentry.op': 'test op',
'sentry.origin': 'auto.test',
'sentry.source': 'task',
},
resource: {
'service.name': 'opentelemetry-test',
'service.namespace': 'sentry',
Expand Down Expand Up @@ -259,14 +253,6 @@ describe('Integration | Transactions', () => {
{ message: 'test breadcrumb 3', timestamp: 123456 },
],
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'test.outer': 'test value',
'sentry.op': 'test op',
'sentry.origin': 'auto.test',
'sentry.source': 'task',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down Expand Up @@ -308,12 +294,6 @@ describe('Integration | Transactions', () => {
{ message: 'test breadcrumb 3b', timestamp: 123456 },
],
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'test.outer': 'test value b',
'sentry.op': 'test op b',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down Expand Up @@ -391,13 +371,6 @@ describe('Integration | Transactions', () => {
expect(beforeSendTransaction).toHaveBeenLastCalledWith(
expect.objectContaining({
contexts: expect.objectContaining({
otel: expect.objectContaining({
attributes: {
'sentry.op': 'test op',
'sentry.origin': 'auto.test',
'sentry.source': 'task',
},
}),
trace: {
data: {
'otel.kind': 'INTERNAL',
Expand Down