Skip to content

test(e2e): Unflake sveltekit e2e tests #11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

test(e2e): Unflake sveltekit e2e tests #11597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions dev-packages/e2e-tests/test-applications/sveltekit-2/test/errors.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ import { waitForInitialPageload } from './utils';

test.describe('client-side errors', () => {
test('captures error thrown on click', async ({ page }) => {
await page.goto('/client-error');

await expect(page.getByText('Client error')).toBeVisible();
await waitForInitialPageload(page, { route: '/client-error', debug: false });

const errorEventPromise = waitForError('sveltekit-2', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
});

const clickPromise = page.getByText('Throw error').click();
await page.getByText('Throw error').click();

await expect(errorEventPromise).resolves.toBeDefined();

const [errorEvent, _] = await Promise.all([errorEventPromise, clickPromise]);
const errorEvent = await errorEventPromise;

const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames;

Expand Down
10 changes: 5 additions & 5 deletions dev-packages/e2e-tests/test-applications/sveltekit/test/errors.client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ import { waitForInitialPageload } from '../utils';

test.describe('client-side errors', () => {
test('captures error thrown on click', async ({ page }) => {
await page.goto('/client-error');

await expect(page.getByText('Client error')).toBeVisible();
await waitForInitialPageload(page, { route: '/client-error', debug: false });

const errorEventPromise = waitForError('sveltekit', errorEvent => {
return errorEvent?.exception?.values?.[0]?.value === 'Click Error';
});

const clickPromise = page.getByText('Throw error').click();
await page.getByText('Throw error').click();

await expect(errorEventPromise).resolves.toBeDefined();

const [errorEvent, _] = await Promise.all([errorEventPromise, clickPromise]);
const errorEvent = await errorEventPromise;

const errorEventFrames = errorEvent.exception?.values?.[0]?.stacktrace?.frames;

Expand Down