Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 15, 2024

Adds a test to ensure isolation scope is correctly applied to express spans, and also that console.log is correctly instrumented.

We have related tests in E2E tests and in other places, but it doesn't hurt to have this explicitly here I guess...

@mydea mydea requested a review from s1gr1d April 15, 2024 08:10
@mydea mydea self-assigned this Apr 15, 2024
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.17 KB (0%)
@sentry/browser (incl. Tracing) 31.77 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) 67.08 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.49 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.92 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.81 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.75 KB (0%)
@sentry/browser (incl. sendFeedback) 26.97 KB (0%)
@sentry/react 24.85 KB (0%)
@sentry/react (incl. Tracing) 34.67 KB (+0.07% 🔺)
@sentry/vue 25.74 KB (+0.02% 🔺)
@sentry/vue (incl. Tracing) 33.48 KB (+0.08% 🔺)
@sentry/svelte 22.3 KB (0%)
CDN Bundle 24.29 KB (0%)
CDN Bundle (incl. Tracing) 32.79 KB (+0.07% 🔺)
CDN Bundle (incl. Tracing, Replay) 66.44 KB (+0.04% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.61 KB (+0.04% 🔺)
CDN Bundle - uncompressed 72.37 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 98.42 KB (+0.07% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 208.08 KB (+0.03% 🔺)
@sentry/nextjs (client) 34.03 KB (+0.06% 🔺)
@sentry/sveltekit (client) 32.27 KB (+0.07% 🔺)
@sentry/node 120.33 KB (0%)

@mydea mydea merged commit 49e095f into develop Apr 15, 2024
@mydea mydea deleted the fn/add-express-isolationScope-test branch April 15, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants