Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 12, 2024

Instead, users can use registerSpanErrorInstrumentation which is now does much less things than before.

I opted to not fully remove this yet because I guess the chance that somebody may have been using this is somewhat high, and we can easily continue to have it with no bundle size hit for those who don't need it. We also couldn't really deprecate this in v7 so I think it's OK to leave this in for now.

Instead, users should use `registerSpanErrorInstrumentation` which is now does much less things than before.
@mydea mydea requested review from AbhiPrasad and Lms24 April 12, 2024 12:30
@mydea mydea self-assigned this Apr 12, 2024
@mydea mydea changed the title feat(core): Depreacte addTracingExtensions feat(core): Deprecate addTracingExtensions Apr 12, 2024
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.17 KB (0%)
@sentry/browser (incl. Tracing) 31.75 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.07 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.47 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.91 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.8 KB (0%)
@sentry/browser (incl. Feedback) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.75 KB (0%)
@sentry/browser (incl. sendFeedback) 26.97 KB (0%)
@sentry/react 24.85 KB (0%)
@sentry/react (incl. Tracing) 34.65 KB (0%)
@sentry/vue 25.74 KB (0%)
@sentry/vue (incl. Tracing) 33.46 KB (0%)
@sentry/svelte 22.3 KB (0%)
CDN Bundle 24.29 KB (-0.05% 🔽)
CDN Bundle (incl. Tracing) 32.77 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing, Replay) 66.42 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.58 KB (-0.03% 🔽)
CDN Bundle - uncompressed 72.37 KB (-0.05% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 98.36 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 208.02 KB (-0.01% 🔽)
@sentry/nextjs (client) 34.01 KB (0%)
@sentry/sveltekit (client) 32.25 KB (0%)
@sentry/node 120.33 KB (0%)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call with leaving it deprecated. I agree, bundle size impact is negligible in this case.

@mydea mydea merged commit 07ca78e into develop Apr 12, 2024
@mydea mydea deleted the fn/remove-tracingExtensions branch April 12, 2024 13:58
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Instead, users can use `registerSpanErrorInstrumentation` which is now
does much less things than before.

I opted to not fully remove this yet because I guess the chance that
somebody may have been using this is somewhat high, and we can easily
continue to have it with no bundle size hit for those who don't need it.
We also couldn't really deprecate this in v7 so I think it's OK to leave
this in for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants