Skip to content

Conversation

@lforst
Copy link
Contributor

@lforst lforst commented Apr 12, 2024

Fixes #11559

Multiple issues:

  • order of matchers
  • escaped regex

@lforst lforst marked this pull request as ready for review April 12, 2024 10:54
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests needed?

@lforst
Copy link
Contributor Author

lforst commented Apr 12, 2024

definitely but gonna do them in a followup cause its a bit of work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants