Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Apr 11, 2024

This also forward-ports the tests from #11555, and adds some more tests.

Node is a different story, will tackle it separately.

@mydea mydea requested review from AbhiPrasad and Lms24 April 11, 2024 14:01
@mydea mydea self-assigned this Apr 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Apr 11, 2024

size-limit report 📦

Path Size
@sentry/browser 22.17 KB (0%)
@sentry/browser (incl. Tracing) 31.77 KB (+0.07% 🔺)
@sentry/browser (incl. Tracing, Replay) 67.08 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.49 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.92 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.81 KB (+0.02% 🔺)
@sentry/browser (incl. Feedback) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.73 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.75 KB (0%)
@sentry/browser (incl. sendFeedback) 26.97 KB (0%)
@sentry/react 24.85 KB (0%)
@sentry/react (incl. Tracing) 34.67 KB (+0.07% 🔺)
@sentry/vue 25.74 KB (+0.02% 🔺)
@sentry/vue (incl. Tracing) 33.48 KB (+0.08% 🔺)
@sentry/svelte 22.3 KB (0%)
CDN Bundle 24.3 KB (0%)
CDN Bundle (incl. Tracing) 32.8 KB (+0.07% 🔺)
CDN Bundle (incl. Tracing, Replay) 66.44 KB (+0.04% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.63 KB (+0.04% 🔺)
CDN Bundle - uncompressed 72.4 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 98.44 KB (+0.07% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 208.1 KB (+0.03% 🔺)
@sentry/nextjs (client) 34.03 KB (+0.06% 🔺)
@sentry/sveltekit (client) 32.27 KB (+0.07% 🔺)
@sentry/node 120.33 KB (0%)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea
Copy link
Member Author

mydea commented Apr 12, 2024

Flaky tests 😭 I'll try to fix them...

@mydea mydea merged commit 478f805 into develop Apr 15, 2024
@mydea mydea deleted the fn/twp branch April 15, 2024 07:53
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
…ry#11561)

This also forward-ports the tests from
getsentry#11555, and adds some
more tests.

Node is a different story, will tackle it separately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants