feat(core): Remove most Hub class exports #11536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Apr 10, 2024
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-remove-hub-class-exports
branch
from
f2c7356 to
98c93ec
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Remove top-level exports of the `Hub` class from all SDK packages. The only package that still exports it is core for now because we temporarily still need the class until we shimmed the return value of `getCurrentHub`. Furthermore also deprecate the `Hub` interface. However, this interface will not be removed in v8 (prob v9) to keep support for `getCurrentHub` during the v8 life cycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes top-level exports of the
Hubclass from all SDK packages. The only package that still exports it is core for now because we temporarily still need the class until we shimmed the return value ofgetCurrentHub. Decided to deprecate the class for now as well, to be aware of where we still use it.Furthermore, this PR also deprecated the
Hubinterface. However, this interface will not be removed in v8 (prob v9) to keep support forgetCurrentHubduring the v8 life cycle.ref #11482