feat(node): Do not exit process by default when other onUncaughtException handlers are registered in onUncaughtExceptionIntegration
#11532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2024 12:58
…ption` handlers are registered in `onUncaughtExceptionIntegration`
AbhiPrasad
approved these changes
Apr 10, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…ption` handlers are registered in `onUncaughtExceptionIntegration` (getsentry#11532)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1661
Ref: #6146
This PR sets the default for the
exitEvenIfOtherHandlersAreRegisteredoption of theonUncaughtExceptionIntegrationtofalse. Effectively this means that going forward, by default, Sentry will not try to exit the process when there are otheronUncaughtExceptionhandlers attached.In the Next.js SDK we needed to override the option for this integration to
false, so now it will be in line with the global default.