fix(metrics): Map statsd to metric_bucket
#11505
Conversation
s1gr1d
force-pushed
the
sig-remove-statsd
branch
from
072afd7 to
1316bd5
Compare
size-limit report 📦
|
s1gr1d
force-pushed
the
sig-remove-statsd
branch
from
1316bd5 to
032baa9
Compare
packages/types/src/datacategory.ts
Outdated
| | 'feedback' | ||
| // Statsd type event for metrics | ||
| | 'statsd' | ||
| // Metrics sent via the statsd or metrics envelope items. `namespace` defines which namespace(s) will be affected |
There was a problem hiding this comment.
what does namespace relate to in this comment?
There was a problem hiding this comment.
That relates to the rate limiting: https://develop.sentry.dev/sdk/rate-limiting/
But it is about the quota_limit responses and might be confusing in this context. Should I remove it? The first sentence should be enough I think.
There was a problem hiding this comment.
yeah I was just confused about the comment in this context as "namespace" is not mentioned in this entry - IMHO OK to remove this or move this comment closer to where namespace is actually used?
There was a problem hiding this comment.
Yeah, I moved the comment to where namespaces is defined
| // See: | ||
| // - https://develop.sentry.dev/sdk/rate-limiting/#definitions | ||
| // - https://github.com/getsentry/relay/blob/c3b339e151c1e548ede489a01c65db82472c8751/relay-common/src/constants.rs#L139-L152 | ||
| // - https://github.com/getsentry/relay/blob/ec791fed9c2260688f25ea6a6d53ab913927e9a5/relay-base-schema/src/data_category.rs#L91 |
There was a problem hiding this comment.
l: Maybe we can just reference master branch here? 🤔 but not sure, feel free to disregard.
There was a problem hiding this comment.
I didn't add it from master, as the file was moved already (why I changed the link). If the link would have been from master, it would've been harder to actually find the correct file as you would just get a 404. But as I could still see the old implementation, it was easier for me to find the new place of the code :)
statsdis the envelope item type andmetric_bucketis the data category. I also changed some variable names to keep a better distinction.