test(e2e/sveltekit): Unflake client error test by waiting for hydration #11469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Apr 8, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…on (getsentry#11469) Attempt to fix the Kit test flakiness by awaiting the initial pageload and hydration, meaning we await - going to the specified route - a custom hydration flag being set - the pageload transaction being sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both SvelteKit e2e test apps have a flaky test that checks for a client-side error to be caught by the SDK. Looks like Kit hydration takes too long in the Playwright env to kick in, leading to our test clicking the error-triggering button before the onclick handler code is registered.
The PR attempts to fix the the flakiness by awaiting the initial pageload, meaning we await
This will prolong the test for a couple of ms but I think that's acceptable.