ref(v8): Remove Transaction concept #11422
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/no-export-transaction
branch
from
e27da11 to
7b355d0
Compare
AbhiPrasad
approved these changes
Apr 4, 2024
|
|
||
| export type AugmentedNextApiResponse = NextApiResponse & { | ||
| __sentryTransaction?: Transaction; | ||
| __sentryTransaction?: SentrySpan; |
There was a problem hiding this comment.
I think we can remove this, nothing seems to use __sentryTransaction
| // In all other cases, use the request's associated transaction (if any) to overwrite the event's `transaction` | ||
| // value with a high-quality one | ||
| const reqWithTransaction = req as { _sentryTransaction?: Transaction }; | ||
| const reqWithTransaction = req as { _sentryTransaction?: Span }; |
There was a problem hiding this comment.
Nothing seems to set _sentryTransaction 🤔
Can we remove all of this functionality here?
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This removes the `Transaction` class and any user facing remainders of this. Now, we just always create a `SentrySpan` class, and this class handles sending the transaction event when it is a root span.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
Transactionclass and any user facing remainders of this.Now, we just always create a
SentrySpanclass, and this class handles sending the transaction event when it is a root span.