feat(sveltekit): Update scope transactionName when pageload route name is updated
#11406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/feat-sveltekit-update-scope-transactionName
branch
from
28f6742 to
0b87667
Compare
size-limit report 📦
|
AbhiPrasad
approved these changes
Apr 3, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…ame is updated (getsentry#11406) Our SvelteKit routing instrumentation updates the pageload rootspan name once we obtain the parameterized route id. This patch now also updates the scope's `transactionName` at this point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our SvelteKit routing instrumentation updates the pageload rootspan name once we obtain the parameterized route id. This PR now also updates the scope's
transactionNameat this point.ref #10846