ref(v8): Remove pushScope, popScope, isOlderThan, shouldSendDefaultPii from hub
#11404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…faultPii` from hub These are the things that will be fully removed in v8 as they do not work anymore at all. The other stuff will remain shimmed for the v8 cycle.
AbhiPrasad
approved these changes
Apr 3, 2024
size-limit report 📦
|
Lms24
approved these changes
Apr 3, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…faultPii` from hub (getsentry#11404) These are the things that will be fully removed in v8 as they do not work anymore at all. The other stuff will remain shimmed for the v8 cycle. I think it is OK to remove `isOlderThan` and `shouldSendDefaultPii` even though they can technically be shimmed as they are not really "main" APIs - but happy to leave this in if we think they are important...?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the things that will be fully removed in v8 as they do not work anymore at all. The other stuff will remain shimmed for the v8 cycle.
I think it is OK to remove
isOlderThanandshouldSendDefaultPiieven though they can technically be shimmed as they are not really "main" APIs - but happy to leave this in if we think they are important...?