feat(node): Add Koa error handler #11403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/koa-error-handler
branch
2 times, most recently
from
22cdffb to
155b812
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/node-koa-app/event-proxy-server.ts
Fixed
Show fixed
Hide fixed
|
|
||
| router1.get('/test-outgoing-fetch/:id', async ctx => { | ||
| const id = ctx.params.id; | ||
| const response = await fetch(`http://localhost:3030/test-inbound-headers/${id}`); |
Check failure
Code scanning / CodeQL
Server-side request forgery
Comment on lines
+126
to
+142
| http | ||
| .request(url, httpRes => { | ||
| httpRes.on('data', chunk => { | ||
| data.push(chunk); | ||
| }); | ||
| httpRes.on('error', error => { | ||
| resolve({ error: error.message, url }); | ||
| }); | ||
| httpRes.on('end', () => { | ||
| try { | ||
| const json = JSON.parse(Buffer.concat(data).toString()); | ||
| resolve(json); | ||
| } catch { | ||
| resolve({ data: Buffer.concat(data).toString(), url }); | ||
| } | ||
| }); | ||
| }) |
Check failure
Code scanning / CodeQL
Server-side request forgery
onurtemizkan
force-pushed
the
onur/koa-error-handler
branch
2 times, most recently
from
fa98837 to
1801be1
Compare
onurtemizkan
force-pushed
the
onur/koa-error-handler
branch
from
1801be1 to
0a74c10
Compare
AbhiPrasad
approved these changes
Apr 5, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Similarly to NestJS instrumentation, this PR adds: - `setupKoaErrorHandler` middleware to capture globally caught exceptions. - Koa end to end tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to NestJS instrumentation, this PR adds:
setupKoaErrorHandlermiddleware to capture globally caught exceptions.