feat(v8): Remove all class based integrations #11345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
lforst and
stephanie-anderson
and removed request for
a team
This comment was marked as off-topic.
This comment was marked as off-topic.
size-limit report 📦
|
timfish
approved these changes
Mar 29, 2024
mydea
reviewed
Apr 2, 2024
| ...windowIntegrations, | ||
| }; | ||
|
|
||
| export { INTEGRATIONS as Integrations }; |
There was a problem hiding this comment.
Just to double check, but we have updated the loader to use this correctly, right?
There was a problem hiding this comment.
yup it should directly grab the top level export!
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
- Removes all class based integrations from `tracing-internal` and re-organizes exports - Removes top level `Integrations` export from browser package resolves getsentry#8844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracing-internaland re-organizes exportsIntegrationsexport from browser packageresolves #8844