Skip to content

Conversation

@timfish
Copy link
Collaborator

@timfish timfish commented Mar 28, 2024

This PR adds some utilities to aid in testing Node HTTP instrumentation and then updates the tests to use the new runner

@timfish timfish requested a review from mydea March 28, 2024 13:56
@codecov
Copy link

codecov bot commented Mar 28, 2024

Bundle Report

Changes will decrease total bundle size by 3.52MB ⬇️

Bundle name Size Change
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry/types-cjs (removed) 35 bytes ⬇️
@sentry-internal/integration-shims-cjs (removed) 3.65kB ⬇️
@sentry/vercel-edge-cjs (removed) 18.23kB ⬇️
@sentry/types-esm (removed) 35 bytes ⬇️
@sentry-internal/replay-cjs (removed) 306.35kB ⬇️
@sentry/node-cjs (removed) 336.97kB ⬇️
@sentry/node-esm (removed) 333.56kB ⬇️
@sentry-internal/integration-shims-esm (removed) 2.99kB ⬇️
@sentry/utils-cjs (removed) 178.75kB ⬇️
@sentry/aws-serverless-cjs (removed) 14.62kB ⬇️
@sentry-internal/replay-canvas-esm (removed) 29.43kB ⬇️
@sentry-internal/replay-esm (removed) 306.46kB ⬇️
@sentry/svelte-cjs (removed) 13.84kB ⬇️
@sentry/astro-cjs (removed) 27.13kB ⬇️
@sentry/vue-cjs (removed) 20.19kB ⬇️
@sentry/vue-esm (removed) 18.85kB ⬇️
@sentry/astro-esm (removed) 23.39kB ⬇️
@sentry/sveltekit-cjs (removed) 69.31kB ⬇️
@sentry-internal/feedback-cjs (removed) 65.56kB ⬇️
@sentry/utils-esm (removed) 174.17kB ⬇️
@sentry/wasm-cjs (removed) 5.2kB ⬇️
@sentry/gatsby-cjs (removed) 905 bytes ⬇️
@sentry/bun-cjs (removed) 13.5kB ⬇️
@sentry-internal/replay-canvas-cjs (removed) 29.51kB ⬇️
@sentry/sveltekit-esm (removed) 61.08kB ⬇️
@sentry/vercel-edge-esm (removed) 16.13kB ⬇️
@sentry/gatsby-esm (removed) 385 bytes ⬇️
@sentry/svelte-esm (removed) 12.72kB ⬇️
@sentry/nextjs-cjs (removed) 20.52kB ⬇️
@sentry/nextjs-esm (removed) 12.53kB ⬇️
@sentry/opentelemetry-cjs (removed) 68.45kB ⬇️
@sentry/browser-cjs (removed) 107.32kB ⬇️
@sentry/remix-cjs (removed) 53.62kB ⬇️
@sentry/react-cjs (removed) 45.04kB ⬇️
@sentry/core-cjs (removed) 240.44kB ⬇️
@sentry-internal/tracing-cjs (removed) 108.01kB ⬇️
@sentry/google-cloud-serverless-cjs (removed) 23.0kB ⬇️
@sentry/remix-esm (removed) 48.23kB ⬇️
@sentry/wasm-esm (removed) 4.85kB ⬇️
@sentry/core-esm (removed) 236.82kB ⬇️
@sentry-internal/feedback-esm (removed) 65.28kB ⬇️
@sentry/react-esm (removed) 41.18kB ⬇️
@sentry/profiling-node-cjs (removed) 25.5kB ⬇️
@sentry/bun-esm (removed) 10.05kB ⬇️
@sentry/google-cloud-serverless-esm (removed) 19.16kB ⬇️
@sentry/opentelemetry-esm (removed) 67.4kB ⬇️
@sentry/browser-esm (removed) 104.51kB ⬇️
@sentry/profiling-node-esm (removed) 25.52kB ⬇️
@sentry-internal/tracing-esm (removed) 107.26kB ⬇️

Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! amazing 🚀

@mydea
Copy link
Member

mydea commented Mar 28, 2024

I'm gonna merge this, then I can convert some more missing tests 🎉

@mydea mydea merged commit ae84d1a into develop Mar 28, 2024
@mydea mydea deleted the timfish/test-node-http-instrumentation branch March 28, 2024 14:55
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
)

This PR adds some utilities to aid in testing Node HTTP instrumentation
and then updates the tests to use the new runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants