ref(node): Remove the old node package
#11322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
Mar 27, 2024
| test('Should populate and propagate sentry baggage if sentry-trace header does not exist', async () => { | ||
| // TODO(v8): Fix this test | ||
| // eslint-disable-next-line jest/no-disabled-tests | ||
| test.skip('Should populate and propagate sentry baggage if sentry-trace header does not exist', async () => { |
There was a problem hiding this comment.
A bunch of the baggage tests are failing, no idea why - this would be good to investigate, maybe @AbhiPrasad you can look into it?
Bundle ReportChanges will decrease total bundle size by 172.1kB ⬇️
|
size-limit report 📦
|
AbhiPrasad
approved these changes
Mar 27, 2024
mydea
force-pushed
the
fn/remove-node-experimental
branch
from
9b00933 to
342c8c5
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
This is not used anymore except in tests, so this PR actually removes the old node package! A few tests are failing now, we should address them before v8 goes stable. For now I marked these to be skipped and added a comment there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not used anymore except in tests, so this PR actually removes the old node package!
A few tests are failing now, we should address them before v8 goes stable. For now I marked these to be skipped and added a comment there.