Skip to content

ref: Remove more usages of getCurrentHub in the codebase #11281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2024
Merged

ref: Remove more usages of getCurrentHub in the codebase #11281

merged 2 commits into from
Mar 26, 2024

Conversation

@AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 26, 2024

The remaining usages are shims + stuff we have for tests. Not sure how much test code we should delete.

@AbhiPrasad AbhiPrasad requested a review from a team March 26, 2024 00:43
@AbhiPrasad AbhiPrasad self-assigned this Mar 26, 2024
@AbhiPrasad AbhiPrasad requested review from lforst and s1gr1d and removed request for a team March 26, 2024 00:43
s1gr1d
s1gr1d approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍🏻

mydea
mydea approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@mydea mydea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link
Contributor

github-actions bot commented Mar 26, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.72 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.06 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.86 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.61 KB (added)
@sentry/browser (incl. Tracing) 36.69 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.69 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.33 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.44 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.45 KB (added)
@sentry/browser (incl. sendFeedback) 27.4 KB (added)
@sentry/browser 22.56 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.08 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.9 KB (added)
CDN Bundle (incl. Tracing) 36.28 KB (added)
CDN Bundle 23.92 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.55 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.5 KB (added)
CDN Bundle - uncompressed 70.85 KB (added)
@sentry/react (incl. Tracing, Replay) 72.03 KB (added)
@sentry/react 22.59 KB (added)

@AbhiPrasad AbhiPrasad merged commit ade0410 into develop Mar 26, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-remove-more-getCurrentHub branch March 26, 2024 13:19
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@AbhiPrasad @cadesalaberry
ref: Remove more usages of getCurrentHub in the codebase (getsentry#1…
94481c4 
…1281)

The remaining usages are shims + stuff we have for tests. Not sure how
much test code we should delete.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mydea mydea mydea approved these changes

@s1gr1d s1gr1d s1gr1d approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-javascript-sdks

Assignees

@AbhiPrasad AbhiPrasad

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AbhiPrasad @mydea @s1gr1d