Skip to content

test: Wait for test server to close #11117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2024
Merged

test: Wait for test server to close #11117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea67aab
test: Wait for test server to close
Mar 15, 2024
825ebb7
🙏
Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions packages/node-experimental/test/transports/http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,15 +80,17 @@ const defaultOptions = {
// empty function to keep test output clean
const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});

describe('makeNewHttpTransport()', () => {
afterEach(() => {
jest.clearAllMocks();

if (testServer) {
testServer.close();
}
});
afterEach(done => {
jest.clearAllMocks();

if (testServer && testServer.listening) {
testServer.close(done);
} else {
done();
}
});

describe('makeNewHttpTransport()', () => {
describe('.send()', () => {
it('should correctly send envelope to server', async () => {
await setupTestServer({ statusCode: SUCCESS }, (req, body) => {
Expand Down
18 changes: 10 additions & 8 deletions packages/node-experimental/test/transports/https.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,15 +82,17 @@ const defaultOptions = {
recordDroppedEvent: () => undefined, // noop
};

describe('makeNewHttpsTransport()', () => {
afterEach(() => {
jest.clearAllMocks();

if (testServer) {
testServer.close();
}
});
afterEach(done => {
jest.clearAllMocks();

if (testServer && testServer.listening) {
testServer.close(done);
} else {
done();
}
});

describe('makeNewHttpsTransport()', () => {
describe('.send()', () => {
it('should correctly send envelope to server', async () => {
await setupTestServer({ statusCode: SUCCESS }, (req, body) => {
Expand Down
18 changes: 10 additions & 8 deletions packages/node/test/transports/http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,17 @@ const defaultOptions = {
// empty function to keep test output clean
const consoleWarnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {});

describe('makeNewHttpTransport()', () => {
afterEach(() => {
jest.clearAllMocks();

if (testServer) {
testServer.close();
}
});
afterEach(done => {
jest.clearAllMocks();

if (testServer && testServer.listening) {
testServer.close(done);
} else {
done();
}
});

describe('makeNewHttpTransport()', () => {
describe('.send()', () => {
it('should correctly send envelope to server', async () => {
await setupTestServer({ statusCode: SUCCESS }, (req, body) => {
Expand Down
18 changes: 10 additions & 8 deletions packages/node/test/transports/https.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,17 @@ const defaultOptions = {
recordDroppedEvent: () => undefined, // noop
};

describe('makeNewHttpsTransport()', () => {
afterEach(() => {
jest.clearAllMocks();

if (testServer) {
testServer.close();
}
});
afterEach(done => {
jest.clearAllMocks();

if (testServer && testServer.listening) {
testServer.close(done);
} else {
done();
}
});

describe('makeNewHttpsTransport()', () => {
describe('.send()', () => {
it('should correctly send envelope to server', async () => {
await setupTestServer({ statusCode: SUCCESS }, (req, body) => {
Expand Down