ci: Re-add size limit action #11096
Merged
ci: Re-add size limit action #11096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/size-limit-fix-it
branch
2 times, most recently
from
5474be6 to
2f84b69
Compare
Contributor
size-limit report 📦
|
add description reorder stuff use old version of artifacts fix dirname fix bump node version fix cwd? skip nextjs for now update limits better log? fix trim it fix size limit creation really fix command?
mydea
force-pushed
the
fn/size-limit-fix-it
branch
from
cf0c524 to
afdc5bf
Compare
lforst
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size seems to be much increased, let's figure this out in follow ups.
Also there is some issue with it reading next.js sizes, also something we can look at in follow ups... I disabled these size checks for now.
The action is now inlined as a package in the monorepo, as our fork has been archived and the upstream package is not really maintained and works pretty different from what we need. Now we at least have full control over this.