Skip to content

feat(replay/v8): Delete deprecated replaySession and errorSampleRates #11045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

feat(replay/v8): Delete deprecated replaySession and errorSampleRates #11045

merged 1 commit into from
Mar 12, 2024

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 12, 2024

Options can be configured with replaysSessionSampleRate and replaysOnErrorSampleRate.
closes #6958

@s1gr1d s1gr1d requested review from Lms24 and mydea March 12, 2024 11:37
@mydea mydea requested a review from billyvg March 12, 2024 11:39
Lms24
Lms24 reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, before merging: Did we already mention this in the migration guide?

These options have been deprecated for a while but let's make sure we mention it at least somewhere.

@s1gr1d
Copy link
Member Author

s1gr1d commented Mar 12, 2024 •
edited
Loading

Actually, before merging: Did we already mention this in the migration guide?

They are mentioned in the replay package here: https://github.com/getsentry/sentry-javascript/blob/develop/packages/replay/MIGRATION.md#replay-sample-rates-are-defined-on-top-level-httpsgithubcomgetsentrysentry-javascriptissues6351

This was added end of 2022, so I don't know if it makes sense to make this more visible 🤔

@Lms24
Copy link
Member

Lms24 commented Mar 12, 2024

This was added end of 2022, so I don't know if it makes sense to make this more visible 🤔

Ahh I see, yeah I think it's fine to leave it as-is. All good from my end 👍

@s1gr1d s1gr1d merged commit c3447d0 into develop Mar 12, 2024
@s1gr1d s1gr1d deleted the sig-remove-deprecated-replay-session branch March 12, 2024 14:21
@s1gr1d s1gr1d self-assigned this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lms24 Lms24 Lms24 approved these changes

@mydea mydea mydea approved these changes

@billyvg billyvg Awaiting requested review from billyvg

Assignees

@s1gr1d s1gr1d

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Delete deprecated Replay session and error sample rates

4 participants

@s1gr1d @Lms24 @mydea