feat(core): Allow custom tracing implementations #11003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And do this for opentelemetry, instead of relying on extra exports. Also needed to move things around a bit to avoid circular dependency build issues.
lforst
approved these changes
Mar 11, 2024
Contributor
lforst
left a comment
lforst
left a comment
There was a problem hiding this comment.
Looks great! One thing though: Would you mind going into a little bit more detail in the PR description? I know all the context around this change because we had this convo offline but future readers might not know that. Thanks!
| export function startSpanManual<T>(options: OpenTelemetrySpanContext, callback: (span: Span) => T): T { | ||
| export function startSpanManual<T>( | ||
| options: OpenTelemetrySpanContext, | ||
| callback: (span: Span, finish: () => void) => T, |
Member
Author
There was a problem hiding this comment.
Aligning the APIs - we talked about removing the finish callback, but it's actually still there in core, we may or may not want to delete it (it's not deprecated so far 😬 ), so I had to add it in the otel implementation as well to make the APIs compatible 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And do this for opentelemetry, instead of relying on extra exports.
Also needed to move things around a bit to avoid circular dependency build issues.
Missing is
getRootSpanwhich is still different, I will update this in a follow up to actually use the same non-enumerable property under the hood so we can use the same implementation there!Reasoning
Until now, we had a core implementation of tracing APIs in
@sentry/core. In@sentry/opentelemetry, we had some alternative implementations, which where instead re-exported in@sentry/node- so if you do e.g. this:You'll get the correct, OTEL-powered performance API - great!
However, if any code would internally do e.g. this:
It would not work, because it would use the non-OTEL-powered API.
This PR addresses this by ensuring we use the same API everywhere when
@sentry/nodeis being used.