Skip to content

Conversation

@mydea
Copy link
Member

@mydea mydea commented Feb 28, 2024

This also resolves the circular dependencies we have in core right now by moving utils around a bit.

This also resolves the circular dependency we have in our build.
@mydea mydea requested review from Lms24, lforst and s1gr1d February 28, 2024 12:56
@mydea mydea self-assigned this Feb 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.17 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.43 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.34 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 61.97 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.65 KB (-0.03% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.65 KB (-0.03% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.81 KB (-0.14% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 30.81 KB (-0.14% 🔽)
@sentry/browser - Webpack (gzipped) 22.09 KB (-0.12% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.58 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.26 KB (-0.11% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.09 KB (-0.16% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.58 KB (-0.37% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.74 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.46 KB (-0.11% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.64 KB (-0.17% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.16 KB (-0.17% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.71 KB (-0.06% 🔽)
@sentry/react - Webpack (gzipped) 22.12 KB (-0.13% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.18 KB (+0.03% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.52 KB (+0.01% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.03 KB (-0.61% 🔽)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mydea mydea merged commit 695b2b0 into develop Feb 28, 2024
@mydea mydea deleted the fn/resolve-circular-dep branch February 28, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants