feat(remix): Set formData as action span data.
#10836
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
changed the title
formData as span data.formData as action span data.
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
from
470ce9e to
3cd1fd2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
dev-packages/e2e-tests/test-applications/create-remix-app-express/event-proxy-server.ts
Fixed
Show fixed
Hide fixed
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
4 times, most recently
from
cf0b64f to
3e92cda
Compare
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
2 times, most recently
from
873a5a1 to
f0490ab
Compare
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
from
8145fb2 to
6ba3dc0
Compare
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
3 times, most recently
from
d225fcb to
5d458fe
Compare
mydea
reviewed
Mar 13, 2024
| action_form_data_test: 'test', | ||
| action_form_data_file: 'file.txt', | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Could you also add the test I added here (or a similar one):
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
from
ad7601f to
e131585
Compare
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
2 times, most recently
from
92f3e76 to
954ac65
Compare
onurtemizkan
commented
Apr 25, 2024
| /* Run your local dev server before starting the tests */ | ||
| webServer: [ | ||
| { | ||
| command: 'pnpm tsx start-event-proxy.ts', |
There was a problem hiding this comment.
I had to switch to tsx from ts-node after hitting TypeStrong/ts-node#1997 and spending hours just to fail to resolve it.
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
from
954ac65 to
f2a604b
Compare
AbhiPrasad
reviewed
Apr 26, 2024
Co-authored-by: Abhijeet Prasad <[email protected]>
AbhiPrasad
approved these changes
Apr 26, 2024
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
from
0c33e85 to
c6980e4
Compare
onurtemizkan
force-pushed
the
onur/remix-express-formdata
branch
from
c6980e4 to
31fa545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #10238
Clones the
requestinactionto readformDataand sets each entry as an attribute to theactionspan.Also adds a new e2e test application using latest Remix with Express, which both tests server and client-side.
There seem to be a few limitations regarding the availability of complete data (multiple file uploads from a single input for example), but I think we can consider this as the best effort.
This will only work when
sendDefaultPiiis set totrue, but we can also add another option to control this.