Skip to content

chore(v8): Clean up some dead code #10831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

chore(v8): Clean up some dead code #10831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fd5d76
chore(v8): Clean up some dead code
AbhiPrasad Feb 27, 2024
fe982ef
Merge branch 'develop' into abhi-cleanup-dead-code
AbhiPrasad Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...s/browser-integration-tests/suites/tracing/browserTracingIntegration/http-timings/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ sentryTest('should create fetch spans with http timing @firefox', async ({ brows
const envelopes = await getMultipleSentryEnvelopeRequests<SerializedEvent>(page, 2, { url, timeout: 10000 });
const tracingEvent = envelopes[envelopes.length - 1]; // last envelope contains tracing data on all browsers

// eslint-disable-next-line deprecation/deprecation
const requestSpans = tracingEvent.spans?.filter(({ op }) => op === 'http.client');

expect(requestSpans).toHaveLength(3);
Expand Down
9 changes: 0 additions & 9 deletions ...sts/suites/tracing/browsertracing/tracePropagationTargets/customTargetsAndOrigins/init.js
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions ...-tests/suites/tracing/browsertracing/tracePropagationTargets/customTracingOrigins/init.js
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/types/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,6 @@ export interface Client<O extends ClientOptions = ClientOptions> {
recordDroppedEvent(reason: EventDropReason, dataCategory: DataCategory, event?: Event): void;

// HOOKS
// TODO(v8): Make the hooks non-optional.
/* eslint-disable @typescript-eslint/unified-signatures */

/**
Expand Down