Skip to content

Fixes latest route name and source not updating correctly #10702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2024
Merged

Fixes latest route name and source not updating correctly #10702

merged 2 commits into from
Feb 22, 2024

Conversation

@edwardgou-sentry
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry commented Feb 16, 2024

latestRouteName and latestRouteSource are immutable strings, so handlers that use these strings do not get the proper latest values when a route update occurs. This update puts the route name and source in an object. Fixes an issue with interaction transactions always using the first pageload transaction route name even though the user has navigated away from the first route name.

@edwardgou-sentry
Copy link
Contributor Author

edwardgou-sentry commented Feb 16, 2024

Planning to use this as a route name tag on inp spans.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 78.43 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.66 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.6 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 63.28 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.62 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.54 KB (+0.08% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.38 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.39 KB (0%)
@sentry/browser - Webpack (gzipped) 22.66 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.72 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 68.21 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 34.03 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 25.05 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 214.99 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 102.78 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 75.08 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 37.19 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 70.03 KB (0%)
@sentry/react - Webpack (gzipped) 22.69 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 87.75 KB (+0.06% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 51.95 KB (+0.09% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.24 KB (0%)

@edwardgou-sentry edwardgou-sentry mentioned this pull request Feb 20, 2024
Merged
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review February 20, 2024 15:49
@edwardgou-sentry edwardgou-sentry mentioned this pull request Feb 20, 2024
Closed
AbhiPrasad
AbhiPrasad approved these changes Feb 20, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this bug was annoying

@edwardgou-sentry edwardgou-sentry merged commit f5985f5 into v7 Feb 22, 2024
@edwardgou-sentry edwardgou-sentry deleted the egou/v7/fix/browser-tracing-latest-route branch February 22, 2024 02:09
mydea added a commit that referenced this pull request Apr 10, 2024
@mydea
fix(v8): Fixes latest route name and source not updating correctly #1…
cef9146 
…0702

Forward port of #10702
@mydea mydea mentioned this pull request Apr 10, 2024
Merged
mydea added a commit that referenced this pull request Apr 11, 2024
@mydea
fix(v8): Fixes latest route name and source not updating correctly #1…
2b38c8e 
…0702

Forward port of #10702
mydea added a commit that referenced this pull request Apr 11, 2024
@mydea
fix(tracing): Fixes latest route name and source not updating correct…
326f52a 
…ly (#11533)

Forward port of
#10702
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@mydea @cadesalaberry
fix(tracing): Fixes latest route name and source not updating correct…
2842911 
…ly (getsentry#11533)

Forward port of
getsentry#10702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edwardgou-sentry @AbhiPrasad